Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove lazy-loading for the images on above-the-fold area and remove CSS aspect-ratio and add transitions to lazy-loaded images #31

Merged

Conversation

anton-karlovskiy
Copy link
Member

@anton-karlovskiy anton-karlovskiy commented Jan 26, 2021

I think we should not lazy-load the images which are within the above-the-fold area for UX.

@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-movies/nuxt-movies/npkc4e0fn
✅ Preview: https://nuxt-movies-git-fork-anton-karlovskiy-perf-cls-with-nuxt-img.nuxt-movies.vercel.app

@anton-karlovskiy
Copy link
Member Author

anton-karlovskiy commented Jan 26, 2021

@pi0 @addyosmani
Re: #26 (comment)

I'm going to remove the aspect ratio by the original CSS as we have nuxt-img module landed and add transitions to the lazy-loaded images using Vue.js transition when they appear (lazy-loaded).

@anton-karlovskiy anton-karlovskiy changed the title [fix] remove lazy-loading for the images on above-the-fold area [fix] remove lazy-loading for the images on above-the-fold area and remove CSS aspect-ratio and add transitions to lazy-loaded images Feb 2, 2021
@anton-karlovskiy anton-karlovskiy self-assigned this Feb 3, 2021
@anton-karlovskiy
Copy link
Member Author

@pi0 @danielroe @addyosmani

I'm going to go ahead and merge this PR although we have not solved the following issues:
#35
#33
#30 (comment)

@anton-karlovskiy anton-karlovskiy merged commit 7daf317 into tastejs:dev Feb 3, 2021
@anton-karlovskiy anton-karlovskiy deleted the perf/cls-with-nuxt-img branch February 3, 2021 20:42
@pi0
Copy link
Member

pi0 commented Feb 3, 2021

Thanks for merging @anton-karlovskiy was going to need it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants