Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web-vitals integration #42

Merged
merged 5 commits into from
Feb 25, 2021
Merged

feat: add web-vitals integration #42

merged 5 commits into from
Feb 25, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 4, 2021

Using web-vitals module for nuxt to collect web-vitals (currently FID, TTFB, LCP, CLS, FCP)

We can send events to either vercel analytics endpoint or google analytics (/cc @addyosmani which one you prefer?)

Also for vercel support, we are in contact with their team to integrate this module since just released vercel support for it.

@vercel
Copy link

vercel bot commented Feb 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-movies/nuxt-movies/HtUxTnxCb1m9i9CYnenDWGWftQMT
✅ Preview: https://nuxt-movies-git-feat-web-vitals-nuxt-movies.vercel.app

@pi0 pi0 changed the title feat: add web-vitals integration [draft] feat: add web-vitals integration Feb 4, 2021
@addyosmani
Copy link
Member

As we are using Vercel for hosting this might be a good opportunity to also try out how well their analytics solution works with CWV for Nuxt. I'd be supportive of Vercel here.

@pi0 pi0 changed the title [draft] feat: add web-vitals integration feat: add web-vitals integration Feb 25, 2021
@pi0
Copy link
Member Author

pi0 commented Feb 25, 2021

Hi @addyosmani. Today vercel team is announcing Vercel Analytics for Nuxt.js 🍾 I have enabled analytics feature in vercel config to try :)

Note: changes in this PR for adding vitals will not be necessary for end-users. I've added it to have more control for debugging for time being. Also we have liberty of changing vitals provider at any time.

@pi0 pi0 merged commit 76d57a7 into dev Feb 25, 2021
@pi0 pi0 deleted the feat/web-vitals branch February 25, 2021 14:23
@pi0 pi0 mentioned this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants