Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serenade.js #90

Closed
addyosmani opened this issue Feb 13, 2012 · 13 comments
Closed

Serenade.js #90

addyosmani opened this issue Feb 13, 2012 · 13 comments
Labels
Milestone

Comments

@addyosmani
Copy link
Member

Something to consider for a future release:

https://github.com/elabs/serenade_todomvc

@sindresorhus
Copy link
Member

@jnicklas Would it be ok if we pulled in your serenade_todomvc as Public Domain?

Would you be interested in updating it to our spec and new template?

@addyosmani
Copy link
Member Author

Minor notes:

  • Currently missing edit state
  • Input needs to be formatted further to match pre 1.0 apps (or 1.0 template)
  • Mark all as complete still checked after all items completed

Sure Sindre will have more if/when we pull this in depending on @jnicklas being interested in us using this.

@JamesMGreene
Copy link

I'd really like to see a Serenade example make it in here as I want learn more about it and compare it with the other MV* frameworks. +1

@sindresorhus
Copy link
Member

@jnicklas ping

@jnicklas
Copy link
Contributor

I'd definitely be interested in getting Serenade into todomvc. My version was rather hasty, and also, as you can see written in CoffeeScript. There are currently a lot of changes happening in Serenade, so I'd rather hold off for a little while until we can get the next release out the door, which should be fairly soon. I'll keep you guys posted!

@sindresorhus
Copy link
Member

Thanks for checking in. Sounds good ;)

@addyosmani
Copy link
Member Author

Tagging as v1.1 (or above). When Serenade is stable, we'd be happy to accept a fresh PR against this :)

@addyosmani
Copy link
Member Author

@jnicklas any updates on the current state of Serenade.js?

@addyosmani
Copy link
Member Author

Looks like Serenade was last updated 2 months ago. Are there still plans for further updates @jnicklas and if not, do you think theres more that could be done to update the existing TodoMVC app you created for it?

@jnicklas
Copy link
Contributor

jnicklas commented Sep 2, 2012

I have a fork with Serenade in todomvc pretty much done. I'll send you a pull request as soon as I have the time. Sorry, I've had so much stuff going on lately. Not a lot of time to focus on OSS.

@sindresorhus
Copy link
Member

@jnicklas Hi Jonas. Just wondering if you would have the time for this any time soon? If not, can you suggest anyone else?

@addyosmani
Copy link
Member Author

Jonas just to echo the above, it would be amazing if you could wrap up what you have into a pull request.

@sindresorhus
Copy link
Member

Fixed in #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants