Added Serenade.js example #409
Conversation
|
I think that we're reasonable when it comes to browser support. If your framework isn't IE8 compatible, obviously we won't expect you to bake in support just for that browser. Thanks for the implementation! We'll review this shortly. |
| form[event:submit=newTodo!] | ||
| h1 "todos" | ||
|
|
||
| input#new-todo[binding:change=@newTitle placeholder="What needs to be done?" autofocus="autofocus"] |
There was a problem hiding this comment.
autofocus="autofocus" -> autofocus
|
Very nice. I think is the least comments I've ever done on a PR here, and most of it is super nitpick. I also like how compact it is :) Can you move it to the labs/architecture-example folder? |
|
I just re-pushed this, moved to the labs folder, and I fixed the issues you found, except for "autofocus". Serenade doesn't support shorthand properties, unfortunately. I've had it requested from a few people, so I'll hopefully add it soon. |
Added Serenade.js example
|
Thanks for eventually doing this @jnicklas :) |
Added Serenade.js example
So this took me way too long, but here, finally, is a todomvc implementation with Serenade.js. I've gone through the specification a couple of times, and I think I have everything in place, let me know if I made any mistakes.
One thing I'm not sure about is that the specification mentions a list of browsers that need to be supported, but the link is broken. Since Serenade doesn't support IE8 or below, obviously the app is not going to work there. Not sure if that's a problem.
Fixes #90