New Todo UI for FlightJS #1138
New Todo UI for FlightJS #1138
Conversation
…t and jasmine-flight are still on bower due to the fact that jasmine-fligth does not exist as an npm module and FlightJS is a UMD bundle at npm.
…irectly from git repos. updated tests and main app
| } | ||
| "name": "flight-todomvc", | ||
| "private": true, | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
name and version isn't needed
|
This is exactly what happens when you are sending PRs seconds before leaving for a coffee! |
| node_modules/ | ||
| node_modules/.bin/* | ||
|
|
||
| node_modules/depot/* |
There was a problem hiding this comment.
The start at the end isn't really needed. Ignoring the folder itself will work too.
|
@sindresorhus I think it is ok. @arthurvr i didn't have time to remove the asterisk. Thanks for the heads up! Gtg |
|
@passy How can you check from Github which commits were not merged? |
|
@sindresorhus I saw you reverted this. I have updated the transient deps, put back the asterisks, and squashed the whole thing. Do you want to sent a new PR? |
|
Hmm, where did I revert this? |
|
Oh, gawd... I didn't mean to push that commit. Fixed now. |
|
@kmargaritis Any idea why c898a78 contains so many changes? |
|
No idea @sindresorhus. Probably @passy has a clue. This is what i sent b6c18e2 |
|
The commits are all in, but I squashed them before merging. I still have no idea what happened with that mega commit. Went through some theories with Sindre, but I'm still in the dark. Sorry for the poopoo. |
Upgraded FlightJS to new Todo ui.