Homepage Polymer 1.1 update ✨ #1507
Conversation
| }, | ||
| "devDependencies": { | ||
| "prefixfree": "91790e8aff6d807cd62018479db2307e1972b92a" | ||
| }, | ||
| "resolutions": { | ||
| "polymer": "^1.1.0", |
There was a problem hiding this comment.
1.2.1 is out. we should use that.
There was a problem hiding this comment.
Cool! The resolutions are no longer necessary with that release either.
|
Pushed the version update as well as the style fixes. All ready for |
|
👍 Lgtm. Wish we would use npm for the dependencies, though. |
|
👍 On npm for dependencies, agree. We don't yet have an official story around this that reliably works, but will update as soon as we do so we can make the switch. Great job updating this, @passy! |
|
My pleasure. ✨ And 👍 for switching over. |
|
@passy mind reopening this whenever you get a chance :) |
|
Did anyone find out what was causing the issue? |
|
oh those links are useless because i did not link to the build :( crap |
|
So I guess we also need to investigate why CI is happy with this. |
|
yeah............ right now we really do not run any tests on the landing page stuff................... :| 🐐 🚽 |
passy
force-pushed
the
polymer-update
branch
from
8db7f8f
to
43dda73
Compare
|
I've fixed the lint issue, but the actual culprit was a missing component from bower. It seems like the partially committed files are only asking for trouble. I've now added all remaining bower files to the PR. How do you feel about adding a bit of extra trash to the repo? |
|
I ❤️ trash |
|
yay manually landed again 💃 thanks @passy you are a champ 💪 |
|
@samccone Thanks for taking the risk. :) 💃 |
|
You are my kind of risk ;) |
Based on @ebidel's recommendation I've updated the homepage to Polymer 1.0 to get some of the performance improvements. It works, but I have no idea if this is idiomatic, especially when it comes to styling.
There are two commits: One for updating all the bower components and one with the actual code changes.
/cc @addyosmani @samccone