New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knockout - routing with crossroad js #218

Merged
merged 3 commits into from Jul 10, 2012

Conversation

Projects
None yet
2 participants
@AlbertoMonteiro
Contributor

AlbertoMonteiro commented Jul 10, 2012

This solution just work with IE 8+
I saw some examples with crossroadjs using hasher js, but it doesnt work good, so I did my own solution to check hash change.

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Jul 10, 2012

Member

Almost! :) Could you have 'All' highlight by default to reflect the routing state when you first land on the page?

Member

addyosmani commented Jul 10, 2012

Almost! :) Could you have 'All' highlight by default to reflect the routing state when you first land on the page?

@AlbertoMonteiro

This comment has been minimized.

Show comment
Hide comment
@AlbertoMonteiro

AlbertoMonteiro Jul 10, 2012

Contributor

For sure, doing it

Contributor

AlbertoMonteiro commented Jul 10, 2012

For sure, doing it

@AlbertoMonteiro

This comment has been minimized.

Show comment
Hide comment
@AlbertoMonteiro

AlbertoMonteiro Jul 10, 2012

Contributor

Done

Contributor

AlbertoMonteiro commented Jul 10, 2012

Done

@AlbertoMonteiro

This comment has been minimized.

Show comment
Hide comment
@AlbertoMonteiro

AlbertoMonteiro Jul 10, 2012

Contributor

Done

Contributor

AlbertoMonteiro commented Jul 10, 2012

Done

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Jul 10, 2012

Member

Perfect. Thanks!

Member

addyosmani commented Jul 10, 2012

Perfect. Thanks!

addyosmani added a commit that referenced this pull request Jul 10, 2012

Merge pull request #218 from AlbertoMonteiro/master
Knockout - routing with crossroad js

@addyosmani addyosmani merged commit 1d83139 into tastejs:master Jul 10, 2012

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013

Merge pull request tastejs#218 from AlbertoMonteiro/master
Knockout - routing with crossroad js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment