Knockout - routing with crossroad js #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost! :) Could you have 'All' highlight by default to reflect the routing state when you first land on the page? |
|
For sure, doing it |
|
Done |
|
Done |
|
Perfect. Thanks! |
addyosmani
added a commit
that referenced
this pull request
Jul 10, 2012
Knockout - routing with crossroad js
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
Knockout - routing with crossroad js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution just work with IE 8+
I saw some examples with crossroadjs using hasher js, but it doesnt work good, so I did my own solution to check hash change.