Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Editing mail templates JS error #948

Closed
myrsk opened this issue Mar 4, 2022 · 2 comments
Closed

[Bug]: Editing mail templates JS error #948

myrsk opened this issue Mar 4, 2022 · 2 comments

Comments

@myrsk
Copy link

myrsk commented Mar 4, 2022

What happened?

When trying to edit email templates, it seems some buttons cant be clicked, and when checking browser console (in both safari and chrome), I can see a JS error

Uncaught SyntaxError: Invalid regular expression: / +[a-zA-Z:_][\w.:-]*(?: *= *"[^"\n]*"| *= *'[^'\n]*'|*=*[^\s"'=<>]+)?/: Nothing to repeat`

This only happens on the templates, not on layout, and not on partial.

With this error, I can't edit the template, or change anything. I can't even click on the links in the left navbar.

What did you expect to happen?

I should be allowed to modify the template text.

Version

Other (please detail)

What browser are you seeing the problem on?

Chrome, Safari

Relevant log output

version 3.3.2
@sampoyigi
Copy link
Member

I've tried so many attempts at reproducing this issue considering it has been reported several times, but still unable to reproduce it. I'll leave this issue open so anyone with the same issue can add more information that would help with reproducing the error.

sampoyigi added a commit that referenced this issue May 20, 2022
…o login and unable to edit mail templates. #970 #948

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi
Copy link
Member

Fixed in v3.5+

sampoyigi added a commit that referenced this issue Nov 26, 2022
- Remove locked property from composer.json manifest (be92fda8)
- Drop asset minification feature to fix JS issue with admin not able to login and unable to edit mail templates. #970 #948 (b9df4df1)
- Add allergens relation to 3.x branch (#978) (ed16a6d3)
- minor fix (e8d87178)
- Fix location_options issue when creating a location #981 (ccbba690)
- minor fixes (721943ae)
- Remove unique validation rule on allergen, category, location, mealtime, menu and table requests (20a9e629)
- Add permissions to order, reservation delete bulk action #986 (16f24e05)
- Add padding to modal form fields container (bc9ceb12)
- Add branch name to split GA (f70ccc7b)
- New admin.list.extendRecords event (#989) (aeb055b7)
- Minor fix (f4996352)
- Use locale dates formats in order and reservation emails (3f5303e6)
- Minor refactor to assignables (d5fd36cc)
- Add location logo mail variables (d91683e9)
- Move allocate table logic from booking manager to reservation mode (a4530bdd)
- Minor fix (4d9bdeb8)
- Add migration to drop all foreign keys due to irritating foreign key errors (ec0542bd)
- Ensure list column names do not much model relation name (5e84a712)
- Check foreign key/index exists before dropping (bbaa0796)
- Use customer email as replyTo when appropriate (tastyigniter/tastyigniter@#1002) (4635985d)
- Ensure guest_num and duration have minimum values (#1001) (a3f024a0)
- use lowest menu option price when menu item price is 0 (137734cb)
- Add location options as HasMany relation (652cb6e2)
- Fix location list order type filter (68e405b0)
- Add comment column to reservations list tastyigniter/ti-ext-reservation#32 (3016c2fd)
- Sort menu item option dropdown alphabetically (f30bbff6)
- Fix issue where cart item option quantity type calculated value is not properly displayed (f2c500cc)
- Update [README.md](http://readme.md/) (b3732a3f)
- Install core update first instead of ignoring non-core updates (2a754e46)
- Fix broken link (a937a00d)
- Minor fix (6486a89d)
- Fix issue where media finder attachment config modal not opening (#1010) (2c1f30d6)
- Minor fix (5bf7b4e7)
- Cache location options (cfe5f965)
- Make location options fields unique (#1011) (5ec9a233)
- Minor fixes (5cbaced6)
- Add support for locationable trait on HasManyThrough, HasOneThrough relationships (da6bc020)
- Allow rendering of multiple list widgets (ed2a9101)
- Fix dashboard news widget feed url (98bc919d)
- Reorder reservation form fields (895d9949)
- Minor UI fix (5e7fbc53)
- Fix issue where reservation list can not be filtered by multiple statuses (de8ec050)
- Ensure admin password max length is 32 when installing (9ceb0251)
- Minor fix (359687ee)
- Fix dashboard charts not displaying data (80a8ba3a)
- Minor refactor (b780b42c)
- Strip html tags from formatted address (88f9243d)
- Support multiple extension paths (#1017) (cd89efb7)
- Allow payments, themes form query to be extended (c61f8de1)
- Fix issue where staff list is empty (3128a19a)
- Code field on mail layouts and partials should always be unique (b8896856)
- Avoid marking order as processed more than once (723ed8c5)
- Minor UI fix (d3da0a09)
- Minor fix (cf831c80)
- Fixed issue where its impossible to unassign a group or staff (aa539055)
- Fix issue with clockpicker positioning and some minor UI adjustments (303444db)
- Avoid negative order total when calculating totals (f9501d9a)
- Fix issue with managing records when recordeditor is in radio mode (c8ff4870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants