-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml io issues for CATS splines #433
Comments
@felipegonzalezco Would it be possible to quickly post a minimal example of the current state and how it should be fixed, to better understand what is the issue, please? That would be very helpful. |
Just to make sure, for the second we need to rename |
For the third, are weights only exported for rational splines or do they need to be exported for non-rational splines as well. |
I updated the code to deal with the first two issues, please check out the branch bf-433 |
After looking through the sources of cats-splinelib, it seems that the static buffer - that fortran splinelib creates for xml.io - is too small to load a "long" line or expects less value per line. Not conclusive yet |
@felipegonzalezco did you try it out? |
Sorry for the late reply. I tried it out and it worked, so the issues are resolved. Thank you for fixing them. |
I found the following problems when generating a spline for CATS SplineLib:
closed
expects at leastsplDim
entrieskntVec
instead ofknotVec
for each individual knot vectorweights
are not optional and must be presentThe text was updated successfully, but these errors were encountered: