Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml io issues for CATS splines #433

Closed
felipegonzalezco opened this issue May 27, 2024 · 9 comments · Fixed by #435
Closed

xml io issues for CATS splines #433

felipegonzalezco opened this issue May 27, 2024 · 9 comments · Fixed by #435
Labels
compatibility Related to external libraries small Small Modifications required (<1h)

Comments

@felipegonzalezco
Copy link

I found the following problems when generating a spline for CATS SplineLib:

  1. the keyword closed expects at least splDim entries
  2. we use kntVec instead of knotVec for each individual knot vector
  3. weights are not optional and must be present
@jzwar
Copy link
Collaborator

jzwar commented May 27, 2024

@felipegonzalezco Would it be possible to quickly post a minimal example of the current state and how it should be fixed, to better understand what is the issue, please? That would be very helpful.

@felipegonzalezco
Copy link
Author

Sure. As examples, here are screenshots of each case.
First, the keyword closed expects splDim entries. Currently, splinepy is writing only one value.
closed

Second, kntVec is used for individual knot vectors. It's kinda consistent with kntVecs which is the vector of knot vectors.
kntVec

And third, I get an error if weights are not defined:
weights

I hope it is more clear now.

@jzwar
Copy link
Collaborator

jzwar commented May 27, 2024

Just to make sure, for the second we need to rename knotVec to kntVec?

@jzwar
Copy link
Collaborator

jzwar commented May 27, 2024

For the third, are weights only exported for rational splines or do they need to be exported for non-rational splines as well.

@jzwar
Copy link
Collaborator

jzwar commented May 27, 2024

I updated the code to deal with the first two issues, please check out the branch bf-433

@jzwar jzwar mentioned this issue May 28, 2024
3 tasks
@j042
Copy link
Member

j042 commented May 28, 2024

After looking through the sources of cats-splinelib, it seems that the static buffer - that fortran splinelib creates for xml.io - is too small to load a "long" line or expects less value per line. Not conclusive yet

@jzwar
Copy link
Collaborator

jzwar commented May 30, 2024

@felipegonzalezco did you try it out?

j042 added a commit that referenced this issue Jun 26, 2024
@j042
Copy link
Member

j042 commented Jun 26, 2024

fixed in #436 and #433. will be available in v0.1.1

@j042 j042 added small Small Modifications required (<1h) compatibility Related to external libraries labels Jun 26, 2024
@felipegonzalezco
Copy link
Author

Sorry for the late reply. I tried it out and it worked, so the issues are resolved. Thank you for fixing them.

@j042 j042 closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Related to external libraries small Small Modifications required (<1h)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants