Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #136 #138

Merged
merged 4 commits into from
May 5, 2023
Merged

fix #136 #138

merged 4 commits into from
May 5, 2023

Conversation

j042
Copy link
Member

@j042 j042 commented Apr 26, 2023

Overview

fixes #136. I guess this won't be merged until another issue is clarified in #136

Addressed issues

  • init with splines would only focus on sharing core spline so far. however, if you pass a modified spline, one expects that new spline is the same as the given spline, no matter what.

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@j042 j042 requested a review from jzwar April 26, 2023 20:24
@jzwar jzwar mentioned this pull request May 2, 2023
Closed
jzwar
jzwar reviewed May 2, 2023
View reviewed changes
splinepy/spline.py Outdated Show resolved Hide resolved
jzwar
jzwar approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@jzwar jzwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling this issue!

splinepy/spline.py Outdated Show resolved Hide resolved
splinepy/spline.py Outdated Show resolved Hide resolved
j042 and others added 2 commits May 3, 2023 13:05
@j042 @jzwar
Apply suggestions from code review
bd52d6b 
Co-authored-by: jzwar <63095162+jzwar@users.noreply.github.com>
@j042
replace unused varaible
fd41725
@j042 j042 merged commit 2a76086 into main May 5, 2023
23 checks passed
@j042 j042 deleted the fix-136 branch May 5, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzwar jzwar jzwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spline init with modified spline
2 participants
@j042 @jzwar