Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spline init with modified spline #136

Closed
j042 opened this issue Apr 24, 2023 · 5 comments · Fixed by #138
Closed

spline init with modified spline #136

j042 opened this issue Apr 24, 2023 · 5 comments · Fixed by #138
Assignees
Labels
bug Something isn't working

Comments

@j042
Copy link
Member

j042 commented Apr 24, 2023

initializing a spline with a spline will takes backend spline, even if the spline has local changes.
Undesired behavior

@j042 j042 self-assigned this Apr 24, 2023
@j042 j042 added the bug Something isn't working label Apr 24, 2023
@jzwar
Copy link
Collaborator

jzwar commented Apr 26, 2023

is also a problem when trying to copy a spline that has not been in use in gustaf.

@j042
Copy link
Member Author

j042 commented Apr 26, 2023

is also a problem when trying to copy a spline that has not been in use in gustaf.

could you give me a simple example?

@j042 j042 mentioned this issue Apr 26, 2023
3 tasks
@jzwar
Copy link
Collaborator

jzwar commented Apr 27, 2023

import gustaf as gus
tt = gus.Bezier(degrees=[1],control_points=[[0,],[1,]])
tt.copy()

produces

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<path>/gustaf/spline/base.py", line 224, in copy
    new.new_core(**self._data["properties"], properties_round_trip=False)
  File "<path>/splinepy/spline.py", line 794, in new_core
    raise RuntimeError(
RuntimeError: dict_keys(['properties_round_trip']) is not valid set of keywords to create a new core for Bezier.Valid ones should include: ('degrees', 'control_points').

@j042
Copy link
Member Author

j042 commented Apr 28, 2023

that part is not valid anymore after this. try the main branch. meanwhile, I will try to bump the version

@jzwar
Copy link
Collaborator

jzwar commented May 2, 2023

Seems to work now after, applying #138

@j042 j042 closed this as completed in #138 May 5, 2023
j042 added a commit that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants