Core implementation of MultiPatch #161
Conversation
j042
changed the title
| } | ||
|
|
||
| // form mismatch info | ||
| std::string mismatch_info{}; |
for more information, see https://pre-commit.ci
|
I am currently checking my scripts with the objective to compare the newly created files to existing ones. So far I still run into some issues, but I think it's because you slightly changed the syntax. I hope to get this sorted out by the end of the day |
|
Happy to announce that it passed the test - except for the two comments I made earlier. I get the same results with both implementations. Hopefully, this proves the validity. |
great! |
Co-authored-by: jzwar <63095162+jzwar@users.noreply.github.com>
| splines=None, | ||
| interfaces=None, | ||
| ): | ||
| def __init__(self, splines=None, interfaces=None, *, spline=None): |
There was a problem hiding this comment.
makes sure spline is only set as keyword. say, Multipatch(splines, interfaces, garbage) will raise TypeError regarding number of positional argument
| ) | ||
|
|
||
| # Transform bezier types, as they are not supported in gismo | ||
| if spline.name.startswith("Bezier"): |
There was a problem hiding this comment.
Here is really where current gustaf functions would shine
There was a problem hiding this comment.
you could use BSpline(splinepy.splinepy_core.same_spline_with_knot_vectors())
Thanks for taking time to review! Next PRs with extended scopes are on their way |
Overview
Implements multipatch core
PyMultiPatch. Functions that require looping over a large array is now implemented in cpp. if applicable, also with multi-threading capabilities.Addressed issues
Checklists