Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplineList features part 1 #147

Closed
wants to merge 46 commits into from
Closed

SplineList features part 1 #147

wants to merge 46 commits into from

Conversation

j042
Copy link
Member

@j042 j042 commented May 17, 2023 •
edited
Loading

Overview

Adds SplineList based query functions. Should serve as base for multi patch. Consider this as progress PR for multi patch. Most of the functions needs elements to have same para_dim and dim beside boundary extraction, thus has a flag check_dims. Here're added functions in this PR

  • evaluate
  • sample
  • extract_boundaries
  • boundary_centers
  • raise_dim_mismatch

Addressed issues

Showcase

A short / one-liner example to highlight the (new) feature

import splinepy

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@j042 j042 requested a review from jzwar May 17, 2023 20:06
@j042 j042 changed the title C multipatch SplineList features part 1 May 17, 2023
@j042
Copy link
Member Author

j042 commented May 24, 2023

we will abandon SplineList, since it causes some issues with pybind not being able to keep python derived class alive

@j042 j042 marked this pull request as draft May 25, 2023 12:06
@j042 j042 marked this pull request as ready for review May 26, 2023 07:48
@j042
Copy link
Member Author

j042 commented May 26, 2023

@jzwar

j042 and others added 23 commits May 26, 2023 15:30
@j042
shared_ptr as holder and splinelist based functions WIP
ae23e6d
@j042
format
74801e0
@j042
format
ecf486d
@j042
fix warning
fd12976
@j042
rough draft of even-ish load
64a63c5
@j042
use min of (total, nthread)
dde6c47
@j042
add fill query option
9b6cb94
@j042
add CheckParaDimAndDim
be4f5c8
@j042
add EvaluateList and SampleList
05a992f
@j042
replace new with D I vector
438115d
@j042
add boundary extract and prepend list_ for splinelist funcs
f3642af
@j042
separate calc boundary center
2342e71
@j042
edit boundary extract and add boundary center
5160d7c
@j042
fix function name and avoid update ListSample
ce9c43f
@pre-commit-ci @j042
[pre-commit.ci] auto fixes from pre-commit.com hooks
e77d6d7 
for more information, see https://pre-commit.ci
@j042
fix comment
cc5e41e
@j042
list functions are now member functions
289fc6e
@j042
add raise_dim_mismatch
a5107fc
@j042
use nthread step query instead of NThreadExecution helper
f6d9e93
@j042
edit comments
198b3c2
@j042
fix typo
c6cadce
@j042
add all test spline creation and add to_derived
9a2256d
@j042
add spline list func tests
6c5d1a0
@j042
Copy link
Member Author

j042 commented Jun 12, 2023

continues in #161

@j042 j042 closed this Jun 12, 2023
@j042 j042 deleted the c-multipatch branch September 11, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzwar jzwar Awaiting requested review from jzwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j042