-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme updates #417
Readme updates #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@property
def microtile(self):
"""Microtile that is either a spline, a list of splines, or a class
that provides a `create_tile` function."""
if hasattr(self, "_microtile"):
return self._microtile
else:
_log.info("microtile is empty. Please checkout splinepy.microstructure.tiles.show() for predefined tile collections!")
return None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, I really really like the modified documentation!
I just had a few minor remarks / questions but generally I approve of the changes made here and you can proceed with the merge! 🚀
Todo: background color, in modification plot nr.1 is wrong |
@jzwar @clemens-fricke are you happy with the background? |
todo: change extract bases' angle |
todo: add |
d9ad532
to
6addec7
Compare
simplified, but still differs from previous version. see #415
they now conform with the NURBS book. 3 < needs to be double checked
Co-authored-by: Daniel Wolff <39346676+danielwolff1@users.noreply.github.com>
…ore straight forward. But it is now not consistent between samples. Please rewiew.
…degree revolve calculation
Overview
Updated readme and documentations to give a better overview of this project. I've also included some chores / clean ups here so that examples in readme works as it is.
Changes are:
splinepy.*
Checklists