-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGR style mouse handler has off-by-one problem #5
Comments
tats
pushed a commit
that referenced
this issue
Aug 4, 2015
Merged. Thank you. |
Also, I'll catch up with the next patch for menu.c. Any comments welcome. Thank you. |
@tats It works for me. I think this code has no risk although it can cause integer overflow. |
tats
pushed a commit
that referenced
this issue
Aug 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@msmhrt reported
120_sgrmouse.patch
has off-by-one issue.The arguments of
process_mouse()
should be mouse position in (0, 0) based coordinate system.But
120_sgrmouse.patch
passes (1, 1) based one.@ttdoda wrote revised patch for this problem. Please check it.
https://gist.github.com/ttdoda/30c189a63d483beeb207
https://gist.github.com/ttdoda/b4e226494fb847e11b66
The text was updated successfully, but these errors were encountered: