Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGR style mouse handler has off-by-one problem #5

Closed
saitoha opened this issue Aug 4, 2015 · 4 comments
Closed

SGR style mouse handler has off-by-one problem #5

saitoha opened this issue Aug 4, 2015 · 4 comments

Comments

@saitoha
Copy link

saitoha commented Aug 4, 2015

@msmhrt reported 120_sgrmouse.patch has off-by-one issue.
The arguments of process_mouse() should be mouse position in (0, 0) based coordinate system.
But 120_sgrmouse.patch passes (1, 1) based one.
@ttdoda wrote revised patch for this problem. Please check it.
https://gist.github.com/ttdoda/30c189a63d483beeb207
https://gist.github.com/ttdoda/b4e226494fb847e11b66
tats pushed a commit that referenced this issue Aug 4, 2015
@ttdoda @tats
Fix that SGR style mouse handler has off-by-one problem
dd05448 
cf. #5
Origin: https://gist.github.com/ttdoda/30c189a63d483beeb207
Bug: https://sourceforge.net/p/w3m/patches/65/
@tats
Copy link
Owner

tats commented Aug 4, 2015

Merged. Thank you.

@tats tats closed this as completed Aug 4, 2015
@tats
Copy link
Owner

tats commented Aug 7, 2015

Also, I'll catch up with the next patch for menu.c.

Any comments welcome. Thank you.

@saitoha
Copy link
Author

saitoha commented Aug 8, 2015

@tats It works for me. I think this code has no risk although it can cause integer overflow.

tats pushed a commit that referenced this issue Aug 8, 2015
@ttdoda @tats
Support SGR style mouse handler for menu
30fdb96 
cf. #5
Origin: https://gist.github.com/ttdoda/83fbcf676a21da28432b
Bug: https://sourceforge.net/p/w3m/patches/65/
@tats
Copy link
Owner

tats commented Aug 8, 2015

@saitoha @ttdoda Merged w3m-sgr-style-menu.diff. Thanks for your contributions.

@kcwu kcwu mentioned this issue Dec 14, 2016
Closed
@rkta rkta mentioned this issue Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tats @saitoha