Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for end of string when parsing Gopher URLs #218

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Check for end of string when parsing Gopher URLs #218

merged 1 commit into from
Feb 19, 2022

Commits on Feb 17, 2022

  1. Check for end of string when parsing Gopher URLs 

    This fixes issue tats#199 reported by Kuang-che Wu.

A specially crafted Gopher URL (e.g. '<a href=gopher:R>') could lead to
an out-of-bounds read.

Problem here was, that 'p' was incremented twice without checking for
the end of the string.

The interesting question for me is: What does this 'if' actually check?
What is special here about the 'R'? I did not find anything related in
RFC 1436 or in RFC 4266.
    @rkta
    rkta committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ba29eb3 View commit details
    Browse the repository at this point in the history