Check for end of string when parsing Gopher URLs #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #199 reported by Kuang-che Wu. A specially crafted Gopher URL (e.g. '<a href=gopher:R>') could lead to an out-of-bounds read. Problem here was, that 'p' was incremented twice without checking for the end of the string. The interesting question for me is: What does this 'if' actually check? What is special here about the 'R'? I did not find anything related in RFC 1436 or in RFC 4266.
|
Though I don't know about the 'R', it's enough to fix the issue, |
|
On Thu, Feb 17, 2022 at 06:36:37AM -0800, Tatsuya Kinoshita wrote:
Though I don't know about the 'R', it's enough to fix the issue,
so acceptable for now.
I just wanted to keep that info tied to the commit for further
reference.
|
|
Sorry, I just realized this was a draft, this was not was I intended. |
|
Merged, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #199 reported by Kuang-che Wu.
A specially crafted Gopher URL (e.g. '') could lead to
an out-of-bounds read.
Problem here was, that 'p' was incremented twice without checking for
the end of the string.
The interesting question for me is: What does this 'if' actually check?
What is special here about the 'R'? I did not find anything related in
RFC 1436 or in RFC 4266.