Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tool 関連の階層変更 #390

Merged
merged 4 commits into from
Jun 13, 2024
Merged

refactor: tool 関連の階層変更 #390

merged 4 commits into from
Jun 13, 2024

Conversation

tatsutakein
Copy link
Member

@tatsutakein tatsutakein commented Jun 13, 2024

Issue

  • close #ISSUE_NUMBER 🦕

概要

tool 関連の階層を変更します。

レビュー観点

レビューレベル

  • Lv0: まったく見ないで Approve する
  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before After

Summary by CodeRabbit

  • Chores
    • ディレクトリパスの統一のため、複数のファイルでパスの更新を行いました。具体的には、/tools//tool/に変更しました。

# ==================== Types ====================
# ✨ feat: 新機能
# 🐛 fix: バグ修正
# 📚 docs: ドキュメントのみの変更
# 💎 style: コードの意味に影響しない変更(空白、書式、セミコロンの欠落など)
# 📦 refactor: バグの修正でも機能の追加でもないコード変更
# 🚀 perf: パフォーマンスを向上させるコード変更
# 🚨 test: 不足しているテストの追加や既存のテストの修正
# 🛠 build: ビルドシステムや外部の依存関係に影響する変更 (スコープの例: gulp, npm)
# ⚙️ ci: CI の設定ファイルやスクリプトの変更 (スコープ例: Travis, Circle)
# ♻️ chore: src やテストファイルを変更しないその他の変更
# 🗑 revert: 以前のコミットを取り消す
@tatsutakein tatsutakein requested a review from a team as a code owner June 13, 2024 14:33
Copy link

coderabbitai bot commented Jun 13, 2024

Walkthrough

この変更の概要は、ファイルパスの整理と統一に関するものです。具体的には、複数のファイルで「tools/」ディレクトリの参照を「tool/」に変更しました。この変更は、構成ファイルやスクリプト、Makefile、ドキュメントの出力パスなどにわたります。

Changes

ファイル 変更概要
.github/CODEOWNERS /tools/から/tool/への所有権の変更
.github/labeler.ymlMakefiletool/bootstrap.sh パスの変更: ./scripts/またはtools/から ./tool/
analysis_options.yaml 除外パターン: tools/bricks/**からbricks/**
bricks/README.md 新しいブリック作成コマンドの出力ディレクトリの変更
mason.yaml ブリックパスの更新: tools/bricks/...からbricks/...

Poem

変更の季節がやってきた、
道具を整理し、道を整える、
新たな地図の示す先、
進化の風が吹き抜ける、
コードの命が踊りだす、
🐇✨ソフトの森に希望を灯す。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the @app/backend Backend development label Jun 13, 2024
@tatsutakeinjp-bot
Copy link
Contributor

Visit the preview URL for this PR (updated for commit b576427):

https://asis-quest-catalog-dev--pr390-refactor-tools-jkhqcjjv.web.app

(expires Thu, 20 Jun 2024 14:34:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5aa3b98f0f68e3358ab4b28a7b45d288ba01e139

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 22d2d7a and b576427.

Files ignored due to path filters (2)
  • backend/pubspec.lock is excluded by !**/*.lock
  • bricks/feature/hooks/pubspec.lock is excluded by !**/*.lock
Files selected for processing (7)
  • .github/CODEOWNERS (1 hunks)
  • .github/labeler.yml (1 hunks)
  • Makefile (1 hunks)
  • analysis_options.yaml (1 hunks)
  • bricks/README.md (1 hunks)
  • mason.yaml (1 hunks)
  • tool/bootstrap.sh (2 hunks)
Files skipped from review due to trivial changes (7)
  • .github/CODEOWNERS
  • .github/labeler.yml
  • Makefile
  • analysis_options.yaml
  • bricks/README.md
  • mason.yaml
  • tool/bootstrap.sh

@tatsutakein tatsutakein merged commit 54257e1 into main Jun 13, 2024
14 checks passed
@tatsutakein tatsutakein deleted the refactor/tools branch June 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@app/backend Backend development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant