Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tt 610 sdk bnb #637

Merged
merged 16 commits into from
Nov 7, 2022
Merged

Feature/tt 610 sdk bnb #637

merged 16 commits into from
Nov 7, 2022

Conversation

jhammer-tatum
Copy link
Contributor

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Oct 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2832dab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TatumBot
Copy link

Task linked: TT-610 SDK -> Core API - BNB

@gitguardian
Copy link

gitguardian bot commented Oct 31, 2022

⚠️ GitGuardian has uncovered 162 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4757440 Generic High Entropy Secret c92edac examples/bnb-example/src/app/bnb.blockchain.example.ts View secret
4757440 Generic High Entropy Secret c92edac examples/bnb-example/src/app/bnb.tx.example.ts View secret
4757440 Generic High Entropy Secret c92edac examples/bnb-example/src/app/bnb.wallet.example.ts View secret
4415156 Generic High Entropy Secret c92edac packages/api-client/src/generated/core/request.ts View secret
4415156 Generic High Entropy Secret 0e87dc0 packages/api-client/src/generated/core/request.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.asa.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.balance.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.blockchain.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.nft.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.nft.express.mint.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.tx.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/algo-example/src/app/algo.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.auction.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.balance.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.blockchain.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.erc20.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.multitoken.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.nft.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.nft.express.mint.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.smartContract.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.tx.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/bsc-example/src/app/bsc.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.balance.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.blockchain.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.custodial.managed.wallet.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.nft.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.spl.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.tx.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/solana-example/src/app/solana.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.balance.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.blockchain.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.nft.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.trc10.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.trc20.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.tx.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/tron-example/src/app/tron.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.balance.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.blockchain.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.gasPump.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.kms.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.tx.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret 5e85948 examples/xdc-example/src/app/xdc.wallet.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.auction.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.balance.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.blockchain.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.erc20.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.multitoken.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.nft.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.nft.express.mint.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.smartContract.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.subscriptions.example.ts View secret
4415145 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.tx.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/klaytn-example/src/app/klaytn.virtualAccount.example.ts View secret
4757440 Generic High Entropy Secret fc7971a examples/xdc-example/src/app/xdc.gasPump.example.ts View secret
4757440 Generic High Entropy Secret 480859b examples/bnb-example/src/app/bnb.tx.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.auction.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.balance.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.blockchain.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.erc20.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.gasPump.examples.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.kms.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.multitoken.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.nft.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.nft.express.mint.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.smartContract.example.ts View secret
4415145 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.subscriptions.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.tx.example.ts View secret
4757440 Generic High Entropy Secret e603441 examples/eth-example/src/app/eth.virtualAccount.example.ts View secret

and 82 others.

🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

2.1% 2.1% Coverage
0.0% 0.0% Duplication

@alexloiko alexloiko merged commit ba0977f into master Nov 7, 2022
@alexloiko alexloiko deleted the feature/TT-610_sdk_bnb branch November 7, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants