Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): fullscreen on Linux when builder is set to Borderless(None) #348

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 25, 2022 21:23
@lucasfernog lucasfernog requested a review from a team as a code owner March 25, 2022 21:23
@wusyong wusyong merged commit 5ecbac1 into dev Mar 26, 2022
@github-actions github-actions bot mentioned this pull request Mar 26, 2022
@lucasfernog lucasfernog deleted the fix/linux-builder-fullscreen branch March 26, 2022 14:39
@meridbt
Copy link

meridbt commented Mar 26, 2023

Hi @lucasfernog,

Have your fix joined master? I can't get expected baheviour on Lubuntu 22.04.2 neither with setting fullscreen property in tauri.conf.json, nor with appWindow.setFullscreen(true).

@lucasfernog
Copy link
Member Author

Yeah this fix is already published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants