Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement set_content_protection, closes #550 #551

Merged
merged 10 commits into from
Sep 4, 2022
Merged

feat: implement set_content_protection, closes #550 #551

merged 10 commits into from
Sep 4, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

@JonasKruckenberg JonasKruckenberg commented Sep 4, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@JonasKruckenberg JonasKruckenberg marked this pull request as ready for review September 4, 2022 13:12
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner September 4, 2022 13:12
@JonasKruckenberg JonasKruckenberg linked an issue Sep 4, 2022 that may be closed by this pull request
[feat] Electron's win.setContentProtection(true); equivalent in Tauri? #550
Closed
amrbashir
amrbashir requested changes Sep 4, 2022
View reviewed changes
.changes/content-protection.md Outdated Show resolved Hide resolved
examples/content_protection.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/window.rs Outdated Show resolved Hide resolved
src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
src/window.rs Outdated Show resolved Hide resolved
JonasKruckenberg and others added 4 commits September 4, 2022 15:26
@JonasKruckenberg @amrbashir
Apply suggestions from code review
c943afb 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@JonasKruckenberg
remove dedicated example
8f56198
@JonasKruckenberg
Merge branch 'feat/content-protection' of https://github.com/tauri-ap…
a305168 
…ps/tao into feat/content-protection
@JonasKruckenberg @amrbashir
Update src/platform_impl/windows/window.rs
d7f78f7 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@JonasKruckenberg
Copy link
Contributor Author

I lost my yubkiey private keys while moving, so my commits aren't verified and it'll take some time for me to set that up again :/

@amrbashir amrbashir merged commit 802146f into dev Sep 4, 2022
@amrbashir amrbashir deleted the feat/content-protection branch September 4, 2022 13:42
@github-actions github-actions bot mentioned this pull request Sep 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Electron's win.setContentProtection(true); equivalent in Tauri?
2 participants
@JonasKruckenberg @amrbashir