Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added text support to system tray for macos, closes #65 #554

Merged
merged 3 commits into from
Sep 10, 2022

Conversation

vojty
Copy link
Contributor

@vojty vojty commented Sep 8, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is just my attempt to finish the work introduced in #369, all credits go to @BenJeau

Tested via RUSTFLAGS='--cfg target_os="macos" --cfg feature="tray"' cargo run --example system_tray

Screen.Recording.2022-09-09.at.9.18.44.mov

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this feature to the finish line, just a few nit-picks to go.

examples/system_tray.rs Outdated Show resolved Hide resolved
examples/system_tray.rs Outdated Show resolved Hide resolved
src/platform/macos.rs Outdated Show resolved Hide resolved
src/platform/macos.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/system_tray.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit 972307d into tauri-apps:dev Sep 10, 2022
@github-actions github-actions bot mentioned this pull request Sep 10, 2022
@BenJeau
Copy link

BenJeau commented Sep 13, 2022

Thanks @vojty for updating my initial PR and having it merged :)

@vojty
Copy link
Contributor Author

vojty commented Sep 14, 2022

@BenJeau np, you did the hard work anyway :) However, I didn't realize that we need to expose this new API to tauri as well. Any help here tauri-apps/tauri#5182 would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants