Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): remove WS_CLIPCHILDREN from window style #839

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 6, 2023

While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of WS_CLIPCHILDREN

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of `WS_CLIPCHILDREN`
@amrbashir amrbashir requested a review from a team as a code owner November 6, 2023 17:30
@wusyong wusyong merged commit c0278d8 into dev Nov 7, 2023
9 checks passed
@wusyong wusyong deleted the fix/windows/remove-ws-clipchildren branch November 7, 2023 04:22
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants