chore(deps): Upgrade to ndk 0.9 and fix thread-safety interactions
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Jul 17, 2024
Package Changes Through f396851There are 1 changes which include tao with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Jul 17, 2024
MarijnS95
commented
Jul 18, 2024
Comment on lines
+5
to
6
| #[cfg(windows)] | ||
| use std::{num::NonZeroU32, rc::Rc}; |
There was a problem hiding this comment.
Note that there are many more "unused import" warnings like this: why the CI not catching those?
amrbashir
reviewed
Jul 18, 2024
Most changes were copied over from my `wry` PR at tauri-apps/wry#1296. Most notably a `&ThreadLooper` is now passed to `wry::android_setup()` because we have one, and it gives important safety guarantees when it comes to registering callbacks on this looper, without (unnecessarily!) requiring `Send`. A thread-local requirement already exists for the `JNIEnv` that is passed around anyway. Also note that certain workarounds and illogical inverted passes around `key_code()` handling are no longer needed, as the `ndk` crate now passes an `enum` with the raw `i32` around so that the `.into()` conversion for `i32` (the correct type) now becomes lossless.
amrbashir
approved these changes
Jul 18, 2024
|
Thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807
Closes #808
Closes #955
Most changes were copied over from my
wryPR at tauri-apps/wry#1296. Most notably a&ThreadLooperis now passed towry::android_setup()because we have one, and it gives important safety guarantees when it comes to registering callbacks on this looper, without (unnecessarily!) requiringSend. A thread-local requirement already exists for theJNIEnvthat is passed around anyway.Also note that certain workarounds and illogical inverted passes around
key_code()handling are no longer needed, as thendkcrate now passes anenumwith the rawi32around so that the.into()conversion fori32(the correct type) now becomes lossless.In the end I'm also quite surprised how many linter warnings trigger in this crate, which don't seem to be down to just linting on an older Rust toolchain?