fix: Replace spaces in asset name with dots, fixes #345 (#374)

* fix: Replace spaces in asset name with dots, fixes #345 * update changefile to be about the feature in general as it's not released yet
tauri-apps · Feb 6, 2023 · 2846fa8 · 2846fa8
1 parent 5ae9606
commit 2846fa8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changes/feat-updater-json.md b/.changes/feat-updater-json.md
@@ -0,0 +1,5 @@
+---
+'action': patch
+---
+
+Automatically generate `latest.json` file for Tauri's updater using the GitHub release as a CDN.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/upload-version-json.ts b/src/upload-version-json.ts
@@ -88,7 +88,9 @@ export async function uploadVersionJSON({
   }
 
   const sigFile = artifacts.find((s) => s.path.endsWith('.sig'));
-  const assetNames = new Set(artifacts.map((p) => getAssetName(p.path)));
+  const assetNames = new Set(
+    artifacts.map((p) => getAssetName(p.path).trim().replace(' ', '.')) // GitHub replaces spaces in asset names with dots
+  );
   let downloadUrl = assets.data
     .filter((e) => assetNames.has(e.name))
     .find(