generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deploy to custom repo #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianLars
requested changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
A few things and then this will be ready to go:
- I think it's fine if you move the context.repo.owner into index.ts when the const is declared instead of falling back to null. Should hopefully make the code even cleaner
- I think the readme changes belongs into the
Release Configuration
block instead. - Please run
pnpm format
after the changes -> I will add the missing github workflow for that check in the meantime. - Lastly, we'll also need a changefile, similar to this one https://github.com/tauri-apps/tauri-action/blob/5eb86f2895edc041147c42d25bee9dc899de189b/.changes/artifacts-output.md?plain=1
Thanks again :)
@FabianLars done, thanks for the reply |
FabianLars
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I don't know why you haven't done this yet, but it's very simple and clear.
The changes allow creating a release in a separate repository, requiring the use of 4 parameters: owner, repo, GITHUB_TOKEN, and releaseCommitish.
I added the description to the readme.