Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose phf #1961

Closed
Kestrer opened this issue Jun 6, 2021 · 2 comments
Closed

Don't expose phf #1961

Kestrer opened this issue Jun 6, 2021 · 2 comments

Comments

@Kestrer
Copy link

Kestrer commented Jun 6, 2021

Tauri currently exposes phf in its public 1.0 API, but phf is not 1.0. This violates C-STABLE.
@lucasfernog
Copy link
Member

phf is only exposed in generated code on the user crate. It should not be used directly. We will document this.

@chippers
Copy link
Member

chippers commented Jun 7, 2021

we should probably mark it #[doc(hidden)] too since that's its only purpose. I mistakenly didn't mark it when exposing it. While it's "breaking" it's not really a big deal since it's straight up a re-export and we didn't plan to support the re-export explicitly

lucasfernog added a commit that referenced this issue Jun 7, 2021
@lucasfernog
chore(core): hide phf, closes #1961
6a29643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chippers @lucasfernog @Kestrer