Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] wrong language code in allowlist for msi bundle #4437

Closed
dolsup opened this issue Jun 22, 2022 · 2 comments
Closed

[bug] wrong language code in allowlist for msi bundle #4437

dolsup opened this issue Jun 22, 2022 · 2 comments
Labels
scope: bundler The bundler used in our cli to make installers type: bug

Comments

@dolsup
Copy link
Contributor

dolsup commented Jun 22, 2022

Describe the bug

Legitimate BCP 47 Code for Korean is ko-KR.
but ko-KO is specified in the file which is used as allowlist.

So, bundling Windows msi fails when tauri.bundle.windows.wix.language in tauri.conf.json is ko-KR.

thread '<unnamed>' panicked at 'Language ko-KR not found. It must be one of et-EE, he-IL, hr-HR, tr-TR, de-DE, pl-PL, sr-Latn-CS, it-IT, eu-ES, da-DK, hu-HU, jp-JP, fi-FI, en-US, es-ES, ca-ES, sk-SK, ro-RO, zh-TW, lt-LT, ru-RU, sv-SE, th-TH, ar-SA, uk-UA, nb-NO, zh-CN, bg-BG, nl-NL, ko-KO, el-GR, sl-SI, vi-VN, lv-LV, cs-CZ, pt-PT, fr-FR, pt-BR', D:\a\tauri\tauri\tooling\bundler\src\bundle\windows\msi\wix.rs:636:7

Reproduction

No response

Expected behavior

ko-KR should be valid language code for the config

Platform and versions

GitHub Actions

Stack trace

No response

Additional context

No response

@dolsup
Copy link
Contributor Author

dolsup commented Jun 22, 2022

I want to fix it and make a PR and It will be a breaking change. But I have no idea that it is okay or not.

@amrbashir
Copy link
Member

thank you, and since it never worked in the first place, it is a bugfix and not a breaking change, so I'd love to see a PR

@amrbashir amrbashir added the scope: bundler The bundler used in our cli to make installers label Jun 22, 2022
dolsup added a commit to dolsup/tauri that referenced this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: bundler The bundler used in our cli to make installers type: bug
Projects
None yet
Development

No branches or pull requests

2 participants