We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legitimate BCP 47 Code for Korean is ko-KR. but ko-KO is specified in the file which is used as allowlist.
ko-KR
ko-KO
tauri/tooling/bundler/src/bundle/windows/msi/languages.json
Line 70 in 6650e5d
So, bundling Windows msi fails when tauri.bundle.windows.wix.language in tauri.conf.json is ko-KR.
tauri.bundle.windows.wix.language
tauri.conf.json
thread '<unnamed>' panicked at 'Language ko-KR not found. It must be one of et-EE, he-IL, hr-HR, tr-TR, de-DE, pl-PL, sr-Latn-CS, it-IT, eu-ES, da-DK, hu-HU, jp-JP, fi-FI, en-US, es-ES, ca-ES, sk-SK, ro-RO, zh-TW, lt-LT, ru-RU, sv-SE, th-TH, ar-SA, uk-UA, nb-NO, zh-CN, bg-BG, nl-NL, ko-KO, el-GR, sl-SI, vi-VN, lv-LV, cs-CZ, pt-PT, fr-FR, pt-BR', D:\a\tauri\tauri\tooling\bundler\src\bundle\windows\msi\wix.rs:636:7
No response
ko-KR should be valid language code for the config
GitHub Actions
The text was updated successfully, but these errors were encountered:
I want to fix it and make a PR and It will be a breaking change. But I have no idea that it is okay or not.
Sorry, something went wrong.
thank you, and since it never worked in the first place, it is a bugfix and not a breaking change, so I'd love to see a PR
fix(bundler): fix language code. closes tauri-apps#4437
6580bfb
08a73ac
No branches or pull requests
Describe the bug
Legitimate BCP 47 Code for Korean is
ko-KR
.but
ko-KO
is specified in the file which is used as allowlist.tauri/tooling/bundler/src/bundle/windows/msi/languages.json
Line 70 in 6650e5d
So, bundling Windows msi fails when
tauri.bundle.windows.wix.language
intauri.conf.json
isko-KR
.Reproduction
No response
Expected behavior
ko-KR
should be valid language code for the configPlatform and versions
Stack trace
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: