Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] (Using wry from git) closing a secondary window crashes the app #9199

Closed
FabianLars opened this issue Mar 16, 2024 · 3 comments · Fixed by tauri-apps/wry#1206
Closed
Assignees
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@FabianLars
Copy link
Member

Describe the bug

This only happens on the wry-git branch where i made tauri use wry's refactor

Whenever you open a window at runtime, and then close/destroy it, it will crash the whole app (crash not exit). I've traced it down to this call: https://github.com/tauri-apps/wry/blob/temp/fabianlars/src/webview2/mod.rs#L1093-L1098 which is called in the InnerWebView drop implementation. Prior to the refactor one week ago this was not called in the drop handler and idk its purpose so i reached out to Amr and he asked for this issue :)

Reproduction

https://github.com/FabianLars/multiwindow-crash

Expected behavior

no crasherino

Full tauri info output

[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 122.0.2365.80
    ✔ MSVC: Visual Studio Build Tools 2022
    ✔ rustc: 1.75.0 (82e1608df 2023-12-21)
    ✔ cargo: 1.75.0 (1d8b05cdd 2023-11-20)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.11.1
    - pnpm: 8.14.1
    - yarn: 1.22.21
    - npm: 10.2.4

[-] Packages
    - tauri [RUST]: git+https://github.com/tauri-apps/tauri?rev=e1bc904fec55d841eb24ef80ea008e02077d93e2#e1bc904fec55d841eb24ef80ea008e02077d93e2 (2.0.0-beta.11)
    - tauri-build [RUST]: no manifest (2.0.0-beta.9, 2.0.0-beta.9)
    - wry [RUST]: git+https://github.com/tauri-apps/wry?rev=549c6637b282443b7a08cb0069ccf372e297646a#549c6637b282443b7a08cb0069ccf372e297646a (0.37.0)
    - tao [RUST]: 0.26.1
    - tauri-cli [RUST]: 2.0.0-beta.9
    - @tauri-apps/api [NPM]: 2.0.0-beta.5
    - @tauri-apps/cli [NPM]: 2.0.0-beta.9

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - bundler: Vite

Stack trace

No response

Additional context

No response

@lucasfernog
Copy link
Member

doesn't seem like this happens in wry (multiwindow example) or when using new_as_child (cargo run --example multiwindow --features unstable in the tauri repo). gonna need Amr on this :(

@Zack-Xb
Copy link

Zack-Xb commented Mar 25, 2024

Any update re this issue ? Is there a workaround solution @lucasfernog ?

Solving this would really help us cause we'd be able to release to a bunch windows users who are waiting.

@FabianLars
Copy link
Member Author

We're still waiting for Amr to get back from vacation and/or sick-leave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants