-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ipc): enhance request URL checks, update wry, refactor file drop #9100
Conversation
Needs the next wry release. |
Updated to wry 0.38 which also requires a small file drop event refactor. |
With the update to the new wry version i'd like to mention #9199. I did not have a chance to test this PR yet though. |
well at least multiwindow is already broken (and now it at least opens the windows properly) |
The difference is that before there was a chance of it crashing (for most apps a pretty small chance I'd say). Now it always crashes :/ If we still want to ship it asap then I'd recommend to release a temporary wry version with the workaround I added until Amr is back. It disables something that wasn't there before the refactor so I hope it's not too bad to disable it. |
it's ok, I think this can wait (I'll forget about it so my anxiety isn't triggered 😂 ) |
@amr-crabnebula can you review this one? there's also a possible blocker in the Windows issue :( |
updated this PR to latest |
Hi - any timeline for this merge? |
No ETA. Shouldn't take too long though since the blocker was resolved 🤷 |
This PR leverages the upcoming wry IPC refactor that exposes the request frame URI on Windows, macOS and iOS (and fallbacks to the main frame URL on unsupported platforms - Linux and Android) along with using the Origin header when the custom-protocol-based IPC is used to determine the request URL instead of using
Webview::url
which only returns the main frame URL. This enhances the check for remote IPC access especially when an iframe is used.