Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipc): enhance request URL checks, update wry, refactor file drop #9100

Merged
merged 14 commits into from
Apr 1, 2024

Conversation

lucasfernog
Copy link
Member

This PR leverages the upcoming wry IPC refactor that exposes the request frame URI on Windows, macOS and iOS (and fallbacks to the main frame URL on unsupported platforms - Linux and Android) along with using the Origin header when the custom-protocol-based IPC is used to determine the request URL instead of using Webview::url which only returns the main frame URL. This enhances the check for remote IPC access especially when an iframe is used.

@lucasfernog lucasfernog requested a review from a team as a code owner March 6, 2024 16:16
@lucasfernog
Copy link
Member Author

Needs the next wry release.

@lucasfernog lucasfernog changed the title feat(ipc): enhance request URL checks feat(ipc): enhance request URL checks, update wry, refactor file drop Mar 19, 2024
@lucasfernog
Copy link
Member Author

Updated to wry 0.38 which also requires a small file drop event refactor.

@FabianLars
Copy link
Member

With the update to the new wry version i'd like to mention #9199. I did not have a chance to test this PR yet though.

@lucasfernog
Copy link
Member Author

well at least multiwindow is already broken (and now it at least opens the windows properly)

@FabianLars
Copy link
Member

The difference is that before there was a chance of it crashing (for most apps a pretty small chance I'd say). Now it always crashes :/

If we still want to ship it asap then I'd recommend to release a temporary wry version with the workaround I added until Amr is back. It disables something that wasn't there before the refactor so I hope it's not too bad to disable it.

@lucasfernog
Copy link
Member Author

it's ok, I think this can wait (I'll forget about it so my anxiety isn't triggered 😂 )

@lucasfernog
Copy link
Member Author

@amr-crabnebula can you review this one? there's also a possible blocker in the Windows issue :(

@amrbashir
Copy link
Member

updated this PR to latest wry, just waiting on a new release of wry

@Jhkier
Copy link

Jhkier commented Mar 30, 2024

Hi - any timeline for this merge?

@FabianLars
Copy link
Member

No ETA. Shouldn't take too long though since the blocker was resolved 🤷

amrbashir
amrbashir previously approved these changes Apr 1, 2024
@lucasfernog lucasfernog merged commit 06833f4 into dev Apr 1, 2024
32 of 33 checks passed
@lucasfernog lucasfernog deleted the feat/enhance-ipc-url-check branch April 1, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants