Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Config option for DMG Volume icon #9253

Open
Blatman opened this issue Mar 22, 2024 · 1 comment
Open

[feat] Config option for DMG Volume icon #9253

Blatman opened this issue Mar 22, 2024 · 1 comment

Comments

@Blatman
Copy link

Blatman commented Mar 22, 2024

Describe the problem

Following on from #4669 which has recently been closed/merged it would be good to have a config option for the Volume icon rather than using the first .icns file in the folder which is the general app icon - the advantage being that the DMG will be readily identifiable as a DMG rather than an app.

dmgicon

Describe the solution you'd like

Work effort should be similar to #4669

dmg-template newconfig

Alternatives considered

Separate DMG bundling can be done with more hassle but this change would be a good value add to the existing build/bundle process which largely runs well

Additional context

No response

@Blatman
Copy link
Author

Blatman commented Mar 23, 2024

Just thinking that maybe all this would require is a change in the bundle_dmg script to use say dmg.icns rather than icon.icns.
This would mean that the dmg.icns could be adapted to suit the devs preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant