feat(cli): include default.toml and capabilities in plugin template #10030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillmann-crabnebula
suggested changes
Jun 11, 2024
| @@ -1,4 +1,4 @@ | |||
| const COMMANDS: &[&str] = &["ping", "execute"]; | |||
There was a problem hiding this comment.
Any specific reason to remove the execute command in this PR?
This breaks the example app UI which invokes the execute command.
There was a problem hiding this comment.
Nice catch, I meant to remove it and replace it with ping, seems like I missed that part, I will update execute usages to be ping instead
tweidinger
approved these changes
Jun 11, 2024
| .with_context(|| "failed to create `permissions` directory")?; | ||
|
|
||
| let default_permissions = r#"[default] |
There was a problem hiding this comment.
One nitpick I noticed "too late" is that this should include a reference to the schema file for autocompletion and validation.
"$schema" = "schemas/schema.json"
pewsheen
pushed a commit
to pewsheen/tauri
that referenced
this pull request
Jun 13, 2024
…auri-apps#10030) * feat(cli): include default.toml and capabilities in plugin template * replace execute usage with ping * add to capabilities * use default permission set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.