Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): window API #1225

merged 3 commits into from
Feb 14, 2021

feat(core): window API #1225

merged 3 commits into from
Feb 14, 2021


Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR extends the window manipulation API (currently we only have setTitle), now every option configurable on tauri.conf.json > tauri > windows can be changed at runtime (position, size, min size, max size, fullscreen, maximized state, minimized state, transparent, always on top, decorations, resizable flag, visibility flag, icon).

@lucasfernog lucasfernog requested a review from a team as a code owner February 13, 2021 01:38
@lucasfernog lucasfernog requested a review from a team February 13, 2021 01:38
Copy link

So exciting!

@lucasfernog lucasfernog merged commit a3d6dff into dev Feb 14, 2021
@lucasfernog lucasfernog deleted the feat/window-api branch February 14, 2021 00:35
Copy link

On the example (and probably on any app with these params) the maxHeight will do nothing if you do not set maxWidth too (same for minHeight as well), and vice versa. Also, putting a debounce on the maxHeight/Width might be a good idea, because now the window will shrink super small as you type in the number since it will set a single-digit value first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants