Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/invoke): separate cmd arg #1321

merged 3 commits into from
Mar 5, 2021


Copy link

@nklayman nklayman commented Mar 4, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Now, the invoke function can now be called with the cmd as the first parameter and the args as the second:

invoke('my_command', {myArg: 'hi'})

The old syntax where everything is an object is still supported.

@nklayman nklayman requested a review from a team as a code owner March 4, 2021 20:45
@nklayman nklayman requested review from a team and lucasfernog March 4, 2021 20:45
api/src/tauri.ts Outdated Show resolved Hide resolved
Copy link

🔥 🔥 🔥

@lucasfernog lucasfernog merged commit 427d170 into dev Mar 5, 2021
@lucasfernog lucasfernog deleted the api-invoke-separate-cmd branch March 5, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants