Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli.rs): inline dialoguer & console until they publish, fixes #1492 #1610

Merged
merged 7 commits into from
Apr 25, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

console-rs/dialoguer#110 (comment)

@lucasfernog
Copy link
Member Author

I'll test this on Windows later.

@lucasfernog
Copy link
Member Author

I'll test this on Windows later.

It works!

@nothingismagick
Copy link
Sponsor Member

Regarding the licensing for console and dialoguer - they are both MIT licensed, so we are not required to do anything at all in the context of this soft fork. It would be "nice" of us to keep their license info though.

Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
@lucasfernog lucasfernog marked this pull request as ready for review April 25, 2021 14:26
@lucasfernog lucasfernog requested a review from a team as a code owner April 25, 2021 14:26
@lucasfernog lucasfernog requested a review from a team April 25, 2021 14:26
@lucasfernog
Copy link
Member Author

Clippy warnings being fixed on another PR.

@lucasfernog lucasfernog merged commit d623d95 into dev Apr 25, 2021
@lucasfernog lucasfernog deleted the fix/dialoguer branch April 25, 2021 14:34
@lucasfernog lucasfernog changed the title fix(cli.rs): inliner dialoguer & console until they publish, fixes #1492 fix(cli.rs): inline dialoguer & console until they publish, fixes #1492 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants