Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow users to access the Assets instance #1691

Merged
merged 2 commits into from
May 3, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Allows Tauri users to access the assets instance, e.g.

fn main() {
  use tauri::Assets;
  let context = tauri::generate_context!();
  let assets = context.assets.clone();
  // now you can read the embedded assets anywhere in the code
  let asset = assets.get("something");
  tauri::Builder::default()
    .run(context)
    .expect("error while running tauri application");
}

@lucasfernog lucasfernog requested a review from a team as a code owner May 3, 2021 17:40
@lucasfernog lucasfernog requested a review from a team May 3, 2021 17:40
@chippers
Copy link
Member

chippers commented May 3, 2021

This change looks fine to me, I don't see any harm in constructing the Arc externally for easy Arc<EmbeddedAssets>. It does currently implement Send + Sync + 'static so references to it should probably work to pass to other things like web servers although I haven't personally tested it.

edit: this is a breaking change so that should be mentioned in the changefile

@lucasfernog
Copy link
Member Author

Using the reference doesn't work since it expects the context to be static. So this change is needed.

@lucasfernog lucasfernog merged commit 5110c70 into dev May 3, 2021
@lucasfernog lucasfernog deleted the feat/allow-assets-usage branch May 3, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants