Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prune packages, add license files, closes #1507 #1769

Merged
merged 5 commits into from May 10, 2021
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: package cleanup

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested review from a team May 10, 2021 17:54
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
@lucasfernog lucasfernog requested a review from a team as a code owner May 10, 2021 19:03
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
@nothingismagick
Copy link
Sponsor Member

when the dust settles here, @lucasfernog - it should be good to merge. I believe I got everything.

@nothingismagick
Copy link
Sponsor Member

It's still worth waiting though, because I did touch Cargo.toml files and mistakes can happen

@lucasfernog lucasfernog merged commit 319cf16 into dev May 10, 2021
@lucasfernog lucasfernog deleted the fix/packaging branch May 10, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants