Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): add package.json to the exports field #1807

Merged
merged 2 commits into from
May 12, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: warning fix

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Just fixing a vite warning, see irclogs/svelte#4 and niieani/hashids.js#330

@lucasfernog lucasfernog requested a review from a team as a code owner May 12, 2021 17:24
@lucasfernog lucasfernog requested a review from a team May 12, 2021 17:24
@@ -17,7 +17,9 @@ if (!pkg.exports) {
const outputPkg = {
...pkg,
exports: Object.assign(
{},
{
'./package.json': './package.json'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just add this to exports in package.json instead of doing it in the after-build.cjs, it won't get overwritten.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds weird either way LOL

Copy link
Member

@amrbashir amrbashir May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is weird, I used to like vite, now I just hate all js bundlers.

@lucasfernog lucasfernog merged commit ab1ea96 into dev May 12, 2021
@lucasfernog lucasfernog deleted the chore/api-exports-package.json branch May 12, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants