Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): improve RPC security, closes #814 #2047

Merged
merged 5 commits into from
Jun 22, 2021
Merged

feat(core): improve RPC security, closes #814 #2047

merged 5 commits into from
Jun 22, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner June 22, 2021 18:21
@lucasfernog lucasfernog requested review from a team June 22, 2021 18:21
@lucasfernog
Copy link
Member Author

Also see tauri-apps/wry#79 (comment)

nothingismagick
nothingismagick approved these changes Jun 22, 2021
View reviewed changes
Copy link
Sponsor Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great. I like the low latency approach!

@lucasfernog lucasfernog merged commit 160fb05 into dev Jun 22, 2021
@lucasfernog lucasfernog deleted the feat/rpc-security branch June 22, 2021 20:29
nklayman
nklayman approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@nklayman nklayman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! This is exactly what I had in mind when I came up with this idea, thanks for implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklayman nklayman nklayman approved these changes

@nothingismagick nothingismagick nothingismagick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasfernog @nklayman @nothingismagick