Skip to content

feat(api.js): add os module#2299

Merged
lucasfernog merged 7 commits intodevfrom
refactor/api-js-to-nodejs
Jul 28, 2021
Merged

feat(api.js): add os module#2299
lucasfernog merged 7 commits intodevfrom
refactor/api-js-to-nodejs

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 27, 2021

First step of #2233

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner July 27, 2021 09:07
@amrbashir amrbashir requested a review from a team July 27, 2021 09:07
@amrbashir amrbashir added the scope: api.js The @tauri-apps/api npm package label Jul 28, 2021
@amrbashir
Copy link
Member Author

amrbashir commented Jul 28, 2021

I don't know if I configured the feature flags and allowlist correctly, so double check this please.

@lucasfernog lucasfernog merged commit 05e679a into dev Jul 28, 2021
@lucasfernog lucasfernog deleted the refactor/api-js-to-nodejs branch July 28, 2021 16:17
@amrbashir amrbashir restored the refactor/api-js-to-nodejs branch July 28, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: api.js The @tauri-apps/api npm package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants