Skip to content

fix(core): ESM detection when using export async function#2425

Merged
lucasfernog merged 1 commit into
devfrom
fix/export-async-esm-detection
Aug 14, 2021
Merged

fix(core): ESM detection when using export async function#2425
lucasfernog merged 1 commit into
devfrom
fix/export-async-esm-detection

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner August 14, 2021 11:39
@lucasfernog lucasfernog requested a review from a team August 14, 2021 11:39
@lucasfernog lucasfernog merged commit fbf8caf into dev Aug 14, 2021
@lucasfernog lucasfernog deleted the fix/export-async-esm-detection branch August 14, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant