feat(cli.js): allow configuring tauri app path on package.json #2752

[lucasfernog]

package.json > tauri > appPath defines the path to the tauri crate and cli.js sets the proper CWD when running cli.rs

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Docs
• New Binding Issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change? (check one)

• Yes. Issue #___
• No

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
• A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

[amrbashir]

if we are gonna add this, then we should probably add the other way around too.
So package.json has a key to link to tauri.conf.json (the file itself is better than the directory) and tauri.conf.json has link to package.json, it probably better to bake that in the rust cli, so rust users can have its benefits too.

[lucasfernog]

if we are gonna add this, then we should probably add the other way around too. So package.json has a key to link to tauri.conf.json (the file itself is better than the directory) and the other way around.

I think the Rust CLI won't even know about Node.js or the frontend application. Currently it only needs this information for tauri info and beforeDev/beforeBuildCommand, and my idea was to allow defining the cwd for the scripts and letting cli.js pass information to cli.rs. This keeps the cli.rs code clean, avoiding this back and forth path information, and makes it easier to have new bindings in the future.

[amrbashir]

Currently it only needs this information for tauri info and beforeDev/beforeBuildCommand, and my idea was to allow defining the cwd for the scripts and letting cli.js pass information to cli.rs.

yeah you're right, this makes more sense.

We also had some reports about some people not able to use the rust cli with a cargo workspace but that's for another PR I guess.

[lucasfernog]

Can you link that issue? Last time I checked it worked fine, maybe it's some special setup.

[amrbashir]

don't remember exactly, maybe it was this #2765 (comment) .

[amrbashir]

we could enhance this a bit using https://github.com/sindresorhus/pkg-up , I know I sometimes run npm clis in a nested directory. this would be a cool addition IMO.

[lucasfernog]

good idea, gonna do it tomorrow

[probablykasper]

pkg-up is literally just calling findUp('package.json', {cwd}) from https://github.com/sindresorhus/find-up, so I'd say use find-up directly

[lucasfernog]

done