fix(cli.rs): prefix the "before script" env vars with TAURI_#3274
Merged
lucasfernog merged 3 commits intonextfrom Jan 24, 2022
Merged
fix(cli.rs): prefix the "before script" env vars with TAURI_#3274lucasfernog merged 3 commits intonextfrom
TAURI_#3274lucasfernog merged 3 commits intonextfrom
Conversation
Member
Author
I caused the problem, I fix the problem lol 😂 |
lucasfernog
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we exported env vars to the "before scripts" (
beforeDevCommandandbeforeBuildCommand) like thisARCH,PLATFORMandVERSIONwhich is problematic for two reasons:ARCHis very generic for example)TAURI_will make life easier and more secure for our tauri+vite users.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix #___, #___)Other information