Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauricon): remove from cli #3293

Merged
merged 5 commits into from
Feb 7, 2022
Merged

feat(tauricon): remove from cli #3293

merged 5 commits into from
Feb 7, 2022

Conversation

nothingismagick
Copy link
Sponsor Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

This PR removes the tauri icon command from the CLI, it can be found at https://github.com/tauri-apps/tauricon

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Tests pass locally with tauri icon removed, and in the new repo as well.

@lucasfernog lucasfernog linked an issue Feb 6, 2022 that may be closed by this pull request
@lucasfernog lucasfernog marked this pull request as ready for review February 7, 2022 02:52
@lucasfernog lucasfernog requested a review from a team as a code owner February 7, 2022 02:52
@lucasfernog lucasfernog requested a review from a team February 7, 2022 02:52
@lucasfernog
Copy link
Member

We're moving the icon command to a dedicated CLI: https://github.com/tauri-apps/tauricon

@lucasfernog lucasfernog merged commit 5803017 into next Feb 7, 2022
@lucasfernog lucasfernog deleted the feat/remove-tauricon branch February 7, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Failed to run yarn create tauri-app
2 participants