fix(api.js) Replace number[]with Uint8Array. fixes #3306#3305
Merged
lucasfernog merged 9 commits intonextfrom Feb 5, 2022
Merged
fix(api.js) Replace number[]with Uint8Array. fixes #3306#3305lucasfernog merged 9 commits intonextfrom
number[]with Uint8Array. fixes #3306#3305lucasfernog merged 9 commits intonextfrom
Conversation
number[]with Uint8Arraynumber[]with Uint8Array
number[]with Uint8Arraynumber[]with Uint8Array. fixes #3306
Member
|
if we merge this we need a changefile too :P |
Member
Author
Throwback to the time I merged a PR and deleted the branch without a changefile and had to open a super embarrassing PR with only a changefile 😂 Edit:
After your comment on the issue, I feel like making this a patch thing is good enough 🤔 Edit2: Not that it matters much, this will result in a major release anyway lol |
Member
|
yeah we did |
number[]with Uint8Array. fixes #3306number[]with Uint8Array. fixes #3306
FabianLars
requested changes
Jan 29, 2022
amrbashir
reviewed
Jan 29, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
attacked issue #3306
Checklist
fix #___, #___)Other information