feat(cli.rs): wait for dev URL to be reachable, exit if command fails #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Feb 8, 2022
tooling/cli.rs/src/dev.rs
Outdated
| } | ||
| }; | ||
| let mut i = 0; | ||
| let sleep_interval = std::time::Duration::from_secs(5); |
There was a problem hiding this comment.
5 seconds is too long, don't you think?
There was a problem hiding this comment.
Hmm tricky. With vite you don't even get into a second iteration, because it's too fast.
With webpack taking like 30 seconds it would get quite spammy with timeouts < 5secs.
Maybe reduce the timeout, but only log the message every x tries?
There was a problem hiding this comment.
yeah I was mainly trying to reduce the spam, since some frameworks like Quasar can take a minute to build. i'll reduce the logging instead.
There was a problem hiding this comment.
pushed, let me know what you think
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
FabianLars
approved these changes
Feb 8, 2022
amrbashir
approved these changes
Feb 8, 2022
|
Yeah the ghost process is part of a separate investigation and PR. |
|
Okay, This PR is fine as is then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Related to #2813