Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli.js): show full error message #3442

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

See https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations

@lucasfernog lucasfernog requested a review from a team February 13, 2022 16:53
@lucasfernog lucasfernog requested a review from a team as a code owner February 13, 2022 16:53
@FabianLars
Copy link
Member

While we're at it, can we print out the actual error here too? https://github.com/tauri-apps/tauri/blob/dev/tooling/cli/src/dev.rs#L324 "failed to run cargo" is really not that helpful. (Made it hard to help someone on discord yesterday)

That may be something for a different PR tho? idk

@lucasfernog
Copy link
Member Author

I'll make that change later as a separate PR.

@lucasfernog lucasfernog merged commit 6382601 into dev Feb 13, 2022
@lucasfernog lucasfernog deleted the feat/improve-cli.js-error branch February 13, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants