Skip to content

feat(core): use AppHandle instead of Window on the updater logic#3702

Merged
lucasfernog merged 2 commits intodevfrom
feat/updater-no-window
Mar 15, 2022
Merged

feat(core): use AppHandle instead of Window on the updater logic#3702
lucasfernog merged 2 commits intodevfrom
feat/updater-no-window

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

  • The updater logic is executed even if no window is initially created
  • The updater emits and listens to events from all windows

@lucasfernog lucasfernog requested a review from a team March 15, 2022 14:28
@lucasfernog lucasfernog requested a review from a team as a code owner March 15, 2022 14:28
@lucasfernog lucasfernog merged commit c4ca80f into dev Mar 15, 2022
@lucasfernog lucasfernog deleted the feat/updater-no-window branch March 15, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant