Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wry): emit RunEvent::Exit on Event::LoopDestroyed #3785

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This allows Tauri to run cleanup code when the exit is not related to the CloseRequested event e.g. macOS dock "quit" click.

@lucasfernog lucasfernog requested a review from a team March 27, 2022 22:36
@lucasfernog lucasfernog requested a review from a team as a code owner March 27, 2022 22:36
This allows Tauri to run cleanup code when the exit is not related to the `CloseRequested` event e.g. macOS dock "quit" click
@lucasfernog lucasfernog merged commit 3c4ee7c into dev Mar 27, 2022
@lucasfernog lucasfernog deleted the refactor/exit branch March 27, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant