Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): improve binary size with api enum serde refactor #3952

Merged
merged 5 commits into from
Apr 24, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: performance improvement

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This was discussed with @chippers and @JonasKruckenberg

@lucasfernog lucasfernog requested a review from a team April 23, 2022 20:30
@lucasfernog lucasfernog requested a review from a team as a code owner April 23, 2022 20:30
@lucasfernog
Copy link
Member Author

Basically this changes the allowlist error message from the runtime to the deserialization step. The binary is 200KB smaller now (release build, stripped).

@lucasfernog lucasfernog changed the base branch from dev to perf/improve-binary-size April 24, 2022 17:07
@lucasfernog
Copy link
Member Author

I'll merge this to a feature branch because there's more improvements to push.

@lucasfernog lucasfernog merged commit c23f139 into perf/improve-binary-size Apr 24, 2022
@lucasfernog lucasfernog deleted the perf/binary-size-api-serde branch April 24, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant